Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image binding and texture cache interface refactor #1481

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

psucien
Copy link
Contributor

@psucien psucien commented Nov 3, 2024

This brings better overlap management and fixes some of the previously observed issues in depth aliasing and mipgens. Known limitations and leftovers:

  • Image size calculation is still a bit off for small CB/DB surfaces
  • Missing MS macro tile params LUTs
  • Depth sub resources won't be merged, and whole image will be created instead
  • In case if a sub resource on right overlap is both a mip and a slice, only mip case will be handled
  • Views on particular slices aren't handled
  • Missing stencil registration

@rafael-57
Copy link

shad_log.txt

Tested Bloodborne, haven't seen any regressions or crashes due to this PR :P

@bigol83
Copy link
Contributor

bigol83 commented Nov 4, 2024

Tried to check what Yakuza 0 texture cache is writing on main menu when there is the wrong orange color on the right part

Immagine 2024-11-04 220707
shad_log.txt

@rafael-57
Copy link

Tried to check what Yakuza 0 texture cache is writing on main menu when there is the wrong orange color on the right part

Immagine 2024-11-04 220707 shad_log.txt

nice catch, would probably be best to add a screenshot of how it looks in main

@bigol83
Copy link
Contributor

bigol83 commented Nov 5, 2024

Tried to check what Yakuza 0 texture cache is writing on main menu when there is the wrong orange color on the right part
Immagine 2024-11-04 220707 shad_log.txt

nice catch, would probably be best to add a screenshot of how it looks in main

It looks like this on main too. This is how it should look

Immagine 2024-11-05 011424

@psucien psucien force-pushed the enfant_terrible branch 2 times, most recently from 25d4a07 to 9e624e6 Compare November 5, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants